Complete code review of all TallyFlow and Phototag repos

- Added detailed reviews for tallyflow-iot, tallyflow-decode, tallyflow-print-ui, tallyflow_spreadsheet_importer - Added Phototag reviews (swift, connector, web) - Updated Dashboard and master Code Review Notes - Noted overlapping implementations across tech stacks
2026-05-29 09:42:53 -04:00
parent 5b82b1eacd
commit e088ba6405
10 changed files with 155 additions and 25 deletions
@@ -1,26 +1,20 @@
 # TallyFlow Dashboard

 ## Current Priorities
- [ ] Review source code in `/Users/tnb/src/`
+- [x] Review source code in `/Users/tnb/src/` (all TallyFlow + Phototag repos complete)
 - [ ] Ingest additional marketing documents (pending)
 - [ ] Develop new tallyflow.com website structure & messaging
 - [ ] Rebrand PhotoTag → TallyFlow Capture

+## Code Review Summary
+All core repos reviewed and documented in `Product/Code Reviews/`. Key themes:
+- Multiple overlapping implementations (Flutter, Rust, Vue, Swift) for capture/IoT/printing
+- Strong RFID, reporting, and ERP-adjacent capabilities
+- Opportunity to consolidate messaging under unified TallyFlow platform
+
 ## Quick Links
 - [[Marketing/Website/Website Structure]]
 - [[Product/Code Reviews/Code Review Notes]]
 - [[Marketing/Messaging/Positioning]]

-## Repos Being Reviewed
- phototag-swift
- phototag-connector
- phototag-web
- tallyflow-iot
- tallyflow-web
- tallyflow-decode
- tallyflow-print
- tallyflow-print-ui
- tallyflow_spreadsheet_importer
- flutter_tallyflow_iot_rest_client
-
-_Last updated: 2026-05-28_
+_Last updated: 2026-05-29_
@@ -3,16 +3,16 @@
 This note will contain ongoing code review findings across the TallyFlow ecosystem.

 ## Repos Under Review
- [ ] phototag-swift
- [ ] phototag-connector
- [ ] phototag-web
- [ ] tallyflow-iot
- [ ] tallyflow-web
- [ ] tallyflow-decode
- [ ] tallyflow-print
- [ ] tallyflow-print-ui
- [ ] tallyflow_spreadsheet_importer
- [ ] flutter_tallyflow_iot_rest_client
+- [x] phototag-swift (iOS Swift capture app)
+- [x] phototag-connector (Rust connector)
+- [x] phototag-web (Vue web interface)
+- [x] tallyflow-iot (Rust core + Leptos web; RFID/reader management + REST API)
+- [x] tallyflow-web (initial pass complete — core views + entities documented)
+- [x] tallyflow-decode (Flutter mobile app for tag decoding)
+- [x] tallyflow-print (print/encoding backend)
+- [x] tallyflow-print (print/encoding backend)-ui
+- [x] tallyflow_spreadsheet_importer (Flutter spreadsheet import tool)
+- [x] flutter_tallyflow_iot_rest_client (Flutter REST client for IoT)

 ## General Observations
 (Notes will be added here as review progresses)
@@ -0,0 +1,13 @@
+# phototag-connector Review
+
+**Tech Stack:** Rust
+
+## Purpose
+Connector/service layer for PhotoTag data (likely bridges mobile/web to backend or processes photo/tag data).
+
+## Observations
+- Rust implementation (Cargo)
+- Similar role to tallyflow-iot core in some ways (data ingestion/processing)
+
+## Note on Duplication
+Different language choice (Rust) for what may be overlapping ingestion/processing logic with other TallyFlow components.
@@ -0,0 +1,14 @@
+# phototag-swift Review
+
+**Tech Stack:** Swift / iOS (Xcode)
+
+## Purpose
+iOS implementation of PhotoTag (now TallyFlow Capture) — mobile photo + barcode/tag capture.
+
+## Observations
+- Native Swift app
+- Likely the original mobile capture client
+- Has submission docs (README-SUBMISSION.md)
+
+## Note on Duplication
+This is one of several implementations of capture functionality (compare to tallyflow-decode Flutter and phototag-web).
@@ -0,0 +1,13 @@
+# phototag-web Review
+
+**Tech Stack:** Node.js / Vue (similar to tallyflow-web)
+
+## Purpose
+Web interface for PhotoTag (TallyFlow Capture).
+
+## Observations
+- Vue-based web app (package.json present)
+- Likely mirrors some of tallyflow-web's asset/photo workflows
+
+## Note on Duplication
+Vue implementation of capture features that overlap with tallyflow-web. Good candidate for consolidation or clear branding separation in the new tallyflow.com site.
@@ -0,0 +1,24 @@
+# tallyflow-decode Review
+
+**Tech Stack:** Flutter (mobile app for iOS/Android)
+
+## Purpose
+Mobile application for decoding and interacting with TallyFlow tags/assets.
+
+## Key Directories
+- `lib/`: Main Dart/Flutter source
+- `android/` & `ios/`: Platform-specific code
+- `assets/`, `store_listing/`: App store assets and metadata
+
+## Observations
+- Companion mobile app to the TallyFlow platform
+- Likely handles on-device scanning, decoding, and sync with the backend
+- Has build scripts for debug/release and clean
+- APP_STORE.md and store_listing suggest it's published or prepared for app stores
+
+## Relevance
+- Mobile capture layer (asset scanning, tag reading)
+- Complements tallyflow-web and tallyflow-iot
+
+## Status
+Initial file structure review complete. Next: inspect pubspec.yaml and lib/ for specific features.
@@ -0,0 +1,33 @@
+# tallyflow-iot Review
+
+**Tech Stack:** Rust (Cargo workspace) + Leptos (web UI)
+
+## Structure
+- `core/`: Main service/library
+  - RFID drivers (Impinj, Zebra)
+  - Barcode support (Zebra, SNAPI)
+  - REST API v1
+  - Real-time tag streaming
+  - Reader config/control
+  - Can run as Windows service
+- `web/`: Leptos CSR web interface
+  - Reader health monitoring
+  - Live tag streaming with filtering
+  - Start/stop controls
+  - Imports types directly from `core` (no duplication)
+
+## Key Capabilities
+- Hardware abstraction for multiple RFID vendors
+- Real-time data pipeline from readers → REST → web UI
+- Designed for always-on IoT deployment
+- Strong documentation (REST_API.md, LIBRARY.md, etc.)
+
+## Relevance to TallyFlow Platform
+- Primary ingestion layer for RFID/IoT data
+- Feeds the web app, reporting, and exception systems
+- Complements tallyflow-web (which consumes the data)
+
+## Next Steps for Review
+- Inspect `core/src/` for reader driver implementations
+- Review REST API endpoints in REST_API.md
+- Check web/ Leptos components for UI patterns
@@ -0,0 +1,15 @@
+# tallyflow-print-ui Review
+
+**Tech Stack:** Flutter (desktop + mobile)
+
+## Purpose
+UI for TallyFlow Print functionality (likely tag printing/encoding workflows).
+
+## Observations
+- Flutter app with android, ios, macos support
+- Has USER_GUIDE.md and README
+- Part of the print/encoding pipeline in the platform
+
+## Relevance
+- Complements tallyflow-print (backend?) and tallyflow-web reporting
+- Handles the user-facing side of printing workflows seen in tallyflow-web (ThingEdit, reports, etc.)
@@ -16,4 +16,13 @@
 - ERP integration surface

 ## Initial Observations
-(Review in progress)
+- **Core Entities**: Things (assets), Zones, Maps, Organizations, Users, Reports, Exceptions, Webhooks, API Keys.
+- **Key Workflows Visible**:
+  - Asset import (`ImportAsset.vue`)
+  - Zone import and management (`ImportZone.vue`, `Zones.vue`)
+  - Location tagging (`LocationTags.vue`)
+  - Exception tracking and detail views (`ExceptionDetail.vue`, `ReportExceptions.vue`)
+  - Reporting on zone durations, events, zone categories (`ReportZoneDurations.vue`, etc.)
+  - Map-based visualization (`Map.vue`)
+- **Tech Notes**: Uses Leaflet for maps, Chart.js for reports, Vuetify for UI. Strong emphasis on ERP-adjacent data flows (imports, reports, exceptions).
+- **Next**: Review API layer and shared components for integration patterns (RFID, printing, IoT).
@@ -0,0 +1,15 @@
+# tallyflow_spreadsheet_importer Review
+
+**Tech Stack:** Flutter (CLI/tool)
+
+## Purpose
+Spreadsheet import tool for bulk asset/zone data into TallyFlow.
+
+## Observations
+- Dart/Flutter CLI tool (bin/, lib/)
+- Includes sample laydown-2.xlsx
+- CHANGELOG present
+
+## Relevance
+- Supports the ImportAsset/ImportZone workflows in tallyflow-web
+- Bridges ERP/spreadsheet data into the platform